Fix Notifier async callback error handling - #2096
Open
timothyanderson096-ocdealcheck wants to merge 5 commits into
Open
Fix Notifier async callback error handling#2096timothyanderson096-ocdealcheck wants to merge 5 commits into
timothyanderson096-ocdealcheck wants to merge 5 commits into
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Route listener exceptions through
Notifier._on_error()when a Notifier is using an asyncio event loop.With a loop configured, thread-backed receivers currently schedule
_on_message_received()usingcall_soon_threadsafe(). Exceptions raised by synchronous listeners therefore occur later on the event-loop thread and bypass_rx_thread()'s exception handler. Coroutine listeners have the same problem because their tasks are only discarded on completion, so task exceptions are never passed to_on_error().This change:
Notifier.exceptionand call_on_error()_on_error(), and keeps cancelled tasks quietThe existing no-loop receive-thread behavior is unchanged.
Fixes #1912.